Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Unicode spechars fix #1128

Merged
merged 2 commits into from
Aug 25, 2017
Merged

Unicode spechars fix #1128

merged 2 commits into from
Aug 25, 2017
+1 −0

Conversation

revolunet
Copy link
Contributor

@revolunet revolunet mentioned this pull request Jul 31, 2017
Closed
MoOx
MoOx suggested changes Aug 9, 2017
View reviewed changes
Copy link
Owner

@MoOx MoOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the unnecessary change in the package.json.
1.0 is not following the same approach but maybe we should check this.

package.json Outdated
@@ -128,7 +128,8 @@
"stylelint": "^7.2.0",
"stylelint-config-standard": "^16.0.0",
"suppose": "^0.6.1",
"webpack": "^2.3.0"
"webpack": "^2.3.0",
"webpack-error-notification": "^0.1.7"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change really necessary? Not sure about this :)

@revolunet
Copy link
Contributor Author

ok, removed the webpack-error-notification dep. had an error with that at some point but whatever :)

@MoOx MoOx merged commit 47f2ade into MoOx:0.21.2 Aug 25, 2017
@MoOx
Copy link
Owner

MoOx commented Aug 25, 2017

0.21.2 is out. Hope ok as I didn't touch 0.x for a while and got issues when installing deps... 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MoOx MoOx MoOx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@revolunet @MoOx